New Adapter: pwbid #2657
New Adapter: pwbid #2657
Conversation
Pwbid pbs
| if impression.Banner != nil { | ||
| return openrtb_ext.BidTypeBanner, nil | ||
| } | ||
| if impression.Native != nil { | ||
| return openrtb_ext.BidTypeNative, nil | ||
| } | ||
| if impression.Video != nil { | ||
| return openrtb_ext.BidTypeVideo, nil | ||
| } |
There was a problem hiding this comment.
Warning - If request has multi format bid, this code will by default set the bid type to Banner. Is that the intention here? Preferred way would be bidder server using MType field available in seatBid.Bid to determine media type
// Attribute:
// mtype
// Type:
// integer
// Description:
// Type of the creative markup so that it can properly be
// associated with the right sub-object of the BidRequest.Imp.
// Values:
// 1 = Banner
// 2 = Video
// 3 = Audio
// 4 = Native
MType MarkupType `json:"mtype,omitempty"`
There was a problem hiding this comment.
I agree with you on this, however I have not been able to find a working example of this. Do you know of an adapter that is accepting multi format bids?
There was a problem hiding this comment.
The IX adapter uses mtype. There is some overhead currently required which will go away in the near future.
prebid-server/adapters/ix/ix.go
Line 245 in afbd867
Several other adapters use custom fields in their response, such as AAX.
prebid-server/adapters/aax/aax.go
Line 96 in afbd867
There was a problem hiding this comment.
Thanks for the examples! @SyntaxNode
Do you have a reference to where this mtype overhead is going to be addressed?
Where we're at now is, let's get this out in the current state, it should be sufficient for our needs and we can update this later. Especially if there's an update in the pipe to make this better.
There was a problem hiding this comment.
Okay. But as fyi, multi-format bid won't be correctly supported by current state
Docs PR: prebid/prebid.github.io#4428